[PATCH] D44804: [StaticAnalyzer] Silence an unused variable warning. NFC.

2018-03-22 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang abandoned this revision. mgrang added a comment. This seems to already have been fixed in r327802. Abandoning this patch. Repository: rC Clang https://reviews.llvm.org/D44804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D44804: [StaticAnalyzer] Silence an unused variable warning. NFC.

2018-03-22 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added a comment. In https://reviews.llvm.org/D44804#1046086, @george.karpenkov wrote: > LGTM, provided it compiles and tests run (`ninja check-clang`) Thanks! Yes, I have already verified it compiles and ninja check-clang is clean. Repository: rC Clang https://reviews.llvm.org/D4480

[PATCH] D44804: [StaticAnalyzer] Silence an unused variable warning. NFC.

2018-03-22 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. LGTM, provided it compiles and tests run (`ninja check-clang`) Repository: rC Clang https://reviews.llvm.org/D44804 ___ cf

[PATCH] D44804: [StaticAnalyzer] Silence an unused variable warning. NFC.

2018-03-22 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang updated this revision to Diff 139503. mgrang added a comment. Addressed comment. Repository: rC Clang https://reviews.llvm.org/D44804 Files: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp Index: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp ===

[PATCH] D44804: [StaticAnalyzer] Silence an unused variable warning. NFC.

2018-03-22 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. Actually, a better change would be to simply change `cast(MR)` to `VR` Repository: rC Clang https://reviews.llvm.org/D44804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D44804: [StaticAnalyzer] Silence an unused variable warning. NFC.

2018-03-22 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang created this revision. mgrang added reviewers: george.karpenkov, dcoughlin, dergachev.a. Herald added subscribers: a.sidorin, szepet. Repository: rC Clang https://reviews.llvm.org/D44804 Files: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp Index: lib/StaticAnalyzer/Checkers/Ret