mgrang abandoned this revision.
mgrang added a comment.
This seems to already have been fixed in r327802. Abandoning this patch.
Repository:
rC Clang
https://reviews.llvm.org/D44804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
mgrang added a comment.
In https://reviews.llvm.org/D44804#1046086, @george.karpenkov wrote:
> LGTM, provided it compiles and tests run (`ninja check-clang`)
Thanks! Yes, I have already verified it compiles and ninja check-clang is clean.
Repository:
rC Clang
https://reviews.llvm.org/D4480
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM, provided it compiles and tests run (`ninja check-clang`)
Repository:
rC Clang
https://reviews.llvm.org/D44804
___
cf
mgrang updated this revision to Diff 139503.
mgrang added a comment.
Addressed comment.
Repository:
rC Clang
https://reviews.llvm.org/D44804
Files:
lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
Index: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
===
george.karpenkov added a comment.
Actually, a better change would be to simply change `cast(MR)` to
`VR`
Repository:
rC Clang
https://reviews.llvm.org/D44804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
mgrang created this revision.
mgrang added reviewers: george.karpenkov, dcoughlin, dergachev.a.
Herald added subscribers: a.sidorin, szepet.
Repository:
rC Clang
https://reviews.llvm.org/D44804
Files:
lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
Index: lib/StaticAnalyzer/Checkers/Ret