[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

MaskRay added inline comments. Herald added a subscriber: arphaman. Comment at: cfe/trunk/test/Driver/sanitizer-ld.c:563 +// RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-X86-64 %s +// CHECK-SHADOWCALLSTACK-LINUX-X86-64-NOT: error: + sanitizer-ld.

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL329122: Add the -fsanitize=shadow-call-stack flag (authored by vlad.tsyrklevich, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44801 Files: c

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

vlad.tsyrklevich updated this revision to Diff 140868. vlad.tsyrklevich added a comment. - Small test, doc updates Repository: rC Clang https://reviews.llvm.org/D44801 Files: docs/ShadowCallStack.rst docs/index.rst include/clang/Basic/Sanitizers.def lib/CodeGen/CGDeclCXX.cpp lib/Co

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

vlad.tsyrklevich added inline comments. Comment at: docs/ShadowCallStack.rst:14 +buffer overflows. It works by saving a function's return address to a +separately allocated 'shadow call stack' in the function prolog and checking the +return address on the stack against the shado

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

kcc accepted this revision. kcc added a comment. LGTM modulo prolog vs prlogue and epilog vs epilogue https://en.wiktionary.org/wiki/epilog says these are alternative spellings, so up to you. Comment at: docs/ShadowCallStack.rst:14 +buffer overflows. It works by saving a func

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

vlad.tsyrklevich updated this revision to Diff 139652. vlad.tsyrklevich marked 6 inline comments as done. vlad.tsyrklevich added a comment. - Address Kostya's documentation feedback Repository: rC Clang https://reviews.llvm.org/D44801 Files: docs/ShadowCallStack.rst docs/index.rst incl

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

kcc added a comment. please also add a short comparison with Intel CET. Repository: rC Clang https://reviews.llvm.org/D44801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

kcc added a comment. [didn't look at the code yet, just at the docs] Please add a docs section describing how to handle leaf functions. If they are not handled yet, no need to change the implementation in these pathches -- ok to do it later. Comment at: docs/ShadowCallStack.

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

vlad.tsyrklevich updated this revision to Diff 139554. vlad.tsyrklevich added a comment. - Add Driver tests Repository: rC Clang https://reviews.llvm.org/D44801 Files: docs/ShadowCallStack.rst docs/index.rst include/clang/Basic/Sanitizers.def lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/C

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Please add a test for the driver functionality. Repository: rC Clang https://reviews.llvm.org/D44801 ___ cfe-commits mailing list cfe-commits@

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

vlad.tsyrklevich created this revision. vlad.tsyrklevich added a reviewer: pcc. Herald added a subscriber: cfe-commits. Add support for the -fsanitize=shadow-call-stack flag which causes clang to add ShadowCallStack attribute to functions compiled with that flag enabled. Repository: rC Clang