This revision was automatically updated to reflect the committed changes.
Closed by commit rL330323: Lowering x86 adds/addus/subs/subus intrinsics
(clang) (authored by aivchenk, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44786
Files:
tkrupa updated this revision to Diff 140401.
Repository:
rC Clang
https://reviews.llvm.org/D44786
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx2-builtins.c
test/CodeGen/avx512bw-builtins.c
test/CodeGen/avx512vlbw-builtins.c
test/CodeGen/sse2-builtins.c
Index: test/CodeGen/sse2-b
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM with that one comment.
Comment at: lib/CodeGen/CGBuiltin.cpp:8288
+llvm::Type *ElementType = ResultType->getVectorElementType();
+llvm::Type *ExtElem
tkrupa updated this revision to Diff 140244.
Repository:
rC Clang
https://reviews.llvm.org/D44786
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx2-builtins.c
test/CodeGen/avx512bw-builtins.c
test/CodeGen/avx512vlbw-builtins.c
test/CodeGen/sse2-builtins.c
Index: test/CodeGen/sse2-b
tkrupa marked 3 inline comments as done.
tkrupa added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:7897
+ Value *MaxVec = CGF.Builder.CreateVectorSplat(NumElements, Max);
+ Value *ExtMaxVec = Signed ? CGF.Builder.CreateSExt(MaxVec, ExtType)
+
craig.topper added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:7897
+ Value *MaxVec = CGF.Builder.CreateVectorSplat(NumElements, Max);
+ Value *ExtMaxVec = Signed ? CGF.Builder.CreateSExt(MaxVec, ExtType)
+: CGF.Builder.CreateZExt(MaxVec,
