[PATCH] D44774: [Driver] Allow use of -fsyntax-only together with -MJ

2018-03-28 Thread David Stenberg via Phabricator via cfe-commits
dstenb added a comment. Our legacy frontend does not support -MJ, so when using that frontend for code generation, we invoke clang with -MJ, and at the same use -fsyntax-only to get the improved diagnostics that clang provides. This is idiosyncratic and probably hacky, I know, but it works well

[PATCH] D44774: [Driver] Allow use of -fsyntax-only together with -MJ

2018-03-26 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. Oh, we certainly should never be hitting an assertion on front-end flags. As such, there is a problem to fix here. I still maintain that the combination of flags is non-sense, so the question is: (1) Should be silently ignore -MJ? That would be useful for your use case, b

[PATCH] D44774: [Driver] Allow use of -fsyntax-only together with -MJ

2018-03-26 Thread David Stenberg via Phabricator via cfe-commits
dstenb added a comment. Downstream we use -MJ in a bit of an idiosyncratic way, as we're in a transition period where we, for a subset of the code base, only use the clang frontend for diagnostics, and not for the code generation. However, if you don't think that using -fsyntax-only and -MJ mak

[PATCH] D44774: [Driver] Allow use of -fsyntax-only together with -MJ

2018-03-23 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. IMO we should explicitly error out. That combination is nonsense to me. Creating useless JSON database fragments is not an improvement. Repository: rC Clang https://reviews.llvm.org/D44774 ___ cfe-commits mailing list cfe-

[PATCH] D44774: [Driver] Allow use of -fsyntax-only together with -MJ

2018-03-22 Thread David Stenberg via Phabricator via cfe-commits
dstenb created this revision. dstenb added reviewers: joerg, klimek, rsmith. Herald added a subscriber: cfe-commits. When using -MJ together with -fsyntax-only, clang would hit an assert in DumpCompilationDatabase() when trying to get the filename for the output field. This patch fixes that by ame