malaperle updated this revision to Diff 139598.
malaperle added a comment.
Use a header for common inclusions for tests
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44764
Files:
unittests/clangd/ClangdTesting.h
unittests/clangd/ClangdTests.cpp
unittests/clangd/ClangdUni
malaperle added a comment.
In https://reviews.llvm.org/D44764#1045682, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D44764#1045648, @simark wrote:
>
> > We could create a file `ClangdTesting.h" which includes everything tested
> > related (gtest, gmock, printers, syncapi, etc). The conven
ilya-biryukov added subscribers: sammccall, hokein, bkramer.
ilya-biryukov added a comment.
In https://reviews.llvm.org/D44764#1045648, @simark wrote:
> We could create a file `ClangdTesting.h" which includes everything tested
> related (gtest, gmock, printers, syncapi, etc). The convention woul
simark added a comment.
We could create a file `ClangdTesting.h" which includes everything tested
related (gtest, gmock, printers, syncapi, etc). The convention would be that
test files would just include that.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44764
__
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM.
I wonder if there's a mechanism to always include the printers when including
`gtest.h`, but having a convention to always include them seems ok for now.
Repository:
rCT
malaperle created this revision.
Herald added subscribers: cfe-commits, MaskRay, ioeric, jkorous-apple,
ilya-biryukov, klimek.
This mitigates a possible issue in tests that print objects on failure. It is
possible that there will be two different instantiations of the printer template
for a given
