[PATCH] D44747: [AMDGPU] Set calling convention for CUDA kernel

2018-03-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D44747#1044916, @yaxunl wrote: > In https://reviews.llvm.org/D44747#1044893, @rjmccall wrote: > > > Is there a reason for this to be done as a special case in IRGen instead of > > just implicitly applying the calling convention in Sema? > > >

[PATCH] D44747: [AMDGPU] Set calling convention for CUDA kernel

2018-03-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D44747#1044893, @rjmccall wrote: > Is there a reason for this to be done as a special case in IRGen instead of > just implicitly applying the calling convention in Sema? The calling convention is not used in Sema, therefore it seems simpler t

[PATCH] D44747: [AMDGPU] Set calling convention for CUDA kernel

2018-03-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 139359. yaxunl added a comment. Upload diff with full context. https://reviews.llvm.org/D44747 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCUDA/kernel-amdgcn.cu Index: test/CodeGenCUDA/kernel-amdgcn.cu =

[PATCH] D44747: [AMDGPU] Set calling convention for CUDA kernel

2018-03-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Is there a reason for this to be done as a special case in IRGen instead of just implicitly applying the calling convention in Sema? https://reviews.llvm.org/D44747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D44747: [AMDGPU] Set calling convention for CUDA kernel

2018-03-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: rjmccall, arsenm. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. This patch sets the calling convention for CUDA kernels required by AMDGPU target. Patch by Greg Rodgers. Lit test added by Yaxun Liu. https://reviews.llvm.o