[PATCH] D44688: Set dso_local for runtime functions

espindola closed this revision. espindola added a comment. 328036 https://reviews.llvm.org/D44688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44688: Set dso_local for runtime functions

espindola added a comment. In https://reviews.llvm.org/D44688#1043575, @rnk wrote: > lgtm > > We don't assume these are `dso_local` on Linux, right? Depends on shouldAssumeDSOLocal. We do if there is no -fPIC or -fPIE for example. https://reviews.llvm.org/D44688 __

[PATCH] D44688: Set dso_local for runtime functions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm We don't assume these are `dso_local` on Linux, right? https://reviews.llvm.org/D44688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D44688: Set dso_local for runtime functions

espindola created this revision. espindola added reviewers: rnk, echristo. This is another case where there is special logic for adding dllimport and so we cannot use setGVProperties. https://reviews.llvm.org/D44688 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/runtime-dllstorage.cp