[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

eugenis accepted this revision. eugenis added a comment. LGTM https://reviews.llvm.org/D44655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

This revision was automatically updated to reflect the committed changes. Closed by commit rC327932: Allow builtins for Cross-DSO CFI on Android (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44655?vs=139062&id=139063#toc Repository: rC Clang https:/

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

phosek updated this revision to Diff 139062. phosek added a comment. SGTM, I've made the test even more explicit. https://reviews.llvm.org/D44655 Files: clang/test/Driver/sanitizer-ld.c Index: clang/test/Driver/sanitizer-ld.c =

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

eugenis added a comment. Since the test is about cfi, not builtins, I think it's better to check for the cfi library explicitly. Repository: rC Clang https://reviews.llvm.org/D44655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

phosek added a comment. I was actually thinking about doing the same now, more specifically using `-rtlib=platform` which is already used elsewhere in this test. Do you prefer one or the other? Repository: rC Clang https://reviews.llvm.org/D44655 _

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

eugenis added a comment. Indeed! https://reviews.llvm.org/D44645 Repository: rC Clang https://reviews.llvm.org/D44655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

phosek added a comment. That link seems to be pointing to this change? Repository: rC Clang https://reviews.llvm.org/D44655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. See my comment in https://reviews.llvm.org/D44655, but this change is also fine with me. Repository: rC Clang https://reviews.llvm.org/D44655 _

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

phosek created this revision. phosek added a reviewer: eugenis. Herald added subscribers: cfe-commits, srhines. This is needed to avoid the test failure in case when compiler-rt is set as the default runtime library for Clang. Repository: rC Clang https://reviews.llvm.org/D44655 Files: cla