hans marked an inline comment as done.
hans added inline comments.
Comment at: include/clang/Basic/DiagnosticParseKinds.td:973
+def warn_pragma_optimize : Warning<
+ "'#pragma optimize' is not supported; use '#pragma clang optimize on|off'
instead">,
+ InGroup;
---
This revision was automatically updated to reflect the committed changes.
hans marked an inline comment as done.
Closed by commit rL327959: [ms] Parse #pragma optimize and ignore it behind its
own flag (authored by hans, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to co
thakis accepted this revision.
thakis added a comment.
Awesome, thanks! One nit below:
Comment at: include/clang/Basic/DiagnosticParseKinds.td:973
+def warn_pragma_optimize : Warning<
+ "'#pragma optimize' is not supported; use '#pragma clang optimize on|off'
instead">,
+ In
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
Comment at: lib/Parse/ParsePragma.cpp:2970
+
+ if (Tok.isNot(tok::l_paren)) {
+PP.Diag(Tok.getLocation(), diag::warn_pragma_expected_lparen) <<
"optimize";
hans created this revision.
hans added reviewers: thakis, rnk.
This allows users to turn off warnings about this pragma specifically, while
still receiving warnings about other ignored pragmas.
https://reviews.llvm.org/D44630
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Bas
