[PATCH] D44628: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs

2018-03-20 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL327984: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs (authored by ibiryukov, committed by ). Hera

[PATCH] D44628: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs

2018-03-20 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. Thanks! I don't know how useful is the support of cfe being checked out somewhere else than into llvm/tools/clang. If we could give up on that, we could just kill this file and rely on clang-tidy to pick up llvm/.clang-tidy. Anyways, LG.

[PATCH] D44628: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs

2018-03-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: .clang-tidy:8 - key: readability-identifier-naming.FunctionCase -value: lowerCase +value: camelBack + - key: readability-identifier-naming.MemberCase simark w

[PATCH] D44628: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs

2018-03-19 Thread Simon Marchi via Phabricator via cfe-commits
simark requested changes to this revision. simark added inline comments. This revision now requires changes to proceed. Comment at: .clang-tidy:8 - key: readability-identifier-naming.FunctionCase -value: lowerCase +value: camelBack + -

[PATCH] D44628: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs

2018-03-19 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: alexfh. ilya-biryukov added a subscriber: simark. ilya-biryukov added a comment. Found by @simark while working on https://reviews.llvm.org/D44272. LLVM .clang_tidy seems to be more up-to-date. Repository: rC Clang https:/

[PATCH] D44628: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs

2018-03-19 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a subscriber: simark. ilya-biryukov added a comment. Found by @simark while working on https://reviews.llvm.org/D44272. Repository: rC Clang https://reviews.llvm.org/D44628 ___ cfe-commits mailing list cfe-commits@lists.llvm.o