[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

sepavloff added a comment. In https://reviews.llvm.org/D44607#1105962, @raj.khem wrote: > Can this be backported to release_60 branch too please ? The patch is compact, clear and addresses stability issue. I think it is worth of backporting to release_60. Repository: rL LLVM https://revie

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

raj.khem added a comment. Can this be backported to release_60 branch too please ? Repository: rL LLVM https://reviews.llvm.org/D44607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

This revision was automatically updated to reflect the committed changes. Closed by commit rL327863: [Driver] Avoid invalidated iterator in insertTargetAndModeArgs (authored by sepavloff, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

marcan added a comment. Note that I don't have commit access, so someone else will have to commit it for me :) Repository: rC Clang https://reviews.llvm.org/D44607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. Thank you! Repository: rC Clang https://reviews.llvm.org/D44607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

marcan updated this revision to Diff 13. Repository: rC Clang https://reviews.llvm.org/D44607 Files: tools/driver/driver.cpp Index: tools/driver/driver.cpp === --- tools/driver/driver.cpp +++ tools/driver/driver.cpp @@ -21

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

sepavloff added a comment. Good catch, thank you. To avoid code duplication you could change `InsertionPoint` into an index and use `begin() + InsertionPoint` in calls to `insert`. Repository: rC Clang https://reviews.llvm.org/D44607 ___ cfe-co

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

marcan added a comment. I'm not sure how to test this. Getting the bug to manifest involves all of having a lot of command line arguments, getting unlucky with the way SmallVectorImpl decides to allocate, and getting unlucky with the glibc allocator deciding to move the data block on realloc (o

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

lebedev.ri added a comment. Tests? Repository: rC Clang https://reviews.llvm.org/D44607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

marcan created this revision. marcan added reviewers: sepavloff, echristo. Herald added a subscriber: cfe-commits. Doing an `.insert()` can potentially invalidate iterators by reallocating the vector's storage. When all the stars align just right, this causes segfaults or glibc aborts. Fix this