phosek abandoned this revision.
phosek added a comment.
Herald added a subscriber: MaskRay.
Herald added a project: All.
No longer needed, this is now the Clang default.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D44605/new/
https://reviews.llvm.org/D44605
___
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm, but we should be sure to advise users who may need to use `-gdwarf-4`
explicitly if their debugging tools become unhappy.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https:/
phosek added a comment.
Herald added a subscriber: abrachet.
@mcgrathr This might be ready to land now.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D44605/new/
https://reviews.llvm.org/D44605
___
cfe-commits mailing l
aprantl added a comment.
I should also point out that even in DWARF v5 mode LLVM does not yet emit DWARF
5 variants of all sections as DWARF v5 support in LLVM is not yet
feature-complete.
Repository:
rC Clang
https://reviews.llvm.org/D44605
__
mcgrathr added a comment.
We aren't actually using DWARF 5 yet AFAICT. Our builds don't pass -gdwarf-5.
So I'm not sure we have yet verified that all the DWARF-consuming tools people
are using with Fuchsia binaries can handle all of DWARF 5 (which has several
major format changes). I'd certa
phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added subscribers: cfe-commits, JDevlieghere, aprantl.
We use DWARF 5 on Fuchsia, make it the toolchain default.
Repository:
rC Clang
https://reviews.llvm.org/D44605
Files:
clang/lib/Driver/ToolChains/Fuchsia.h
clang
