[PATCH] D44557: [analyzer] CStringChecker.cpp - Code refactoring on bug report.

2018-04-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC330589: [analyzer] CStringChecker.cpp - Code refactoring on bug report. (authored by henrywong, committed by ). Changed prior to commit: https://reviews.llvm.org/D44557?vs=138682&id=143545#toc Reposito

[PATCH] D44557: [analyzer] CStringChecker.cpp - Code refactoring on bug report.

2018-04-21 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang https://reviews.llvm.org/D44557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44557: [analyzer] CStringChecker.cpp - Code refactoring on bug report.

2018-03-20 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In https://reviews.llvm.org/D44557#1042792, @MTC wrote: > In https://reviews.llvm.org/D44557#1042357, @NoQ wrote: > > > Sorry, one moment, i'm seeing a few regressions after the previous > > refactoring but i didn't look at them closely yet to provide a reproducer. > > I'll

[PATCH] D44557: [analyzer] CStringChecker.cpp - Code refactoring on bug report.

2018-03-19 Thread Henry Wong via Phabricator via cfe-commits
MTC added a comment. In https://reviews.llvm.org/D44557#1042357, @NoQ wrote: > Sorry, one moment, i'm seeing a few regressions after the previous > refactoring but i didn't look at them closely yet to provide a reproducer. > I'll get back to this. Thank you for the code review, @NoQ ! The re

[PATCH] D44557: [analyzer] CStringChecker.cpp - Code refactoring on bug report.

2018-03-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Sorry, one moment, i'm seeing a few regressions after the previous refactoring but i didn't look at them closely yet to provide a reproducer. I'll get back to this. Repository: rC Clang https://reviews.llvm.org/D44557 ___ c

[PATCH] D44557: [analyzer] CStringChecker.cpp - Code refactoring on bug report.

2018-03-16 Thread Henry Wong via Phabricator via cfe-commits
MTC created this revision. MTC added reviewers: NoQ, george.karpenkov, xazax.hun. Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet. When improving the modeling `evalMemset()`, some scenes need to emit report of `NotNullTerm`. In this case, there are three places in `CStringChec