[PATCH] D44533: [AMDGPU] Fix codegen for inline assembly

This revision was automatically updated to reflect the committed changes. Closed by commit rC328359: [AMDGPU] Fix codegen for inline assembly (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D44533 Files: lib/Basic/Targets/AMDGPU.h lib/CodeGen/CGStmt.cpp

[PATCH] D44533: [AMDGPU] Fix codegen for inline assembly

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D44533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D44533: [AMDGPU] Fix codegen for inline assembly

yaxunl added a comment. Ping https://reviews.llvm.org/D44533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44533: [AMDGPU] Fix codegen for inline assembly

yaxunl updated this revision to Diff 138768. yaxunl marked an inline comment as done. yaxunl added a comment. Fix the comment. https://reviews.llvm.org/D44533 Files: lib/Basic/Targets/AMDGPU.h lib/CodeGen/CGStmt.cpp test/CodeGenOpenCL/inline-asm-amdgcn.cl test/Sema/inline-asm-validate-a

[PATCH] D44533: [AMDGPU] Fix codegen for inline assembly

arsenm added inline comments. Comment at: lib/Basic/Targets/AMDGPU.h:288 + // Constraint parm will be left pointing at the last character of + // the constraint. In practice, it won't be changed unless the parm? https://reviews.llvm.org/D44533 _

[PATCH] D44533: [AMDGPU] Fix codegen for inline assembly

yaxunl created this revision. yaxunl added reviewers: arsenm, rampitec, b-sumner. Herald added subscribers: eraman, t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl. Need to override convertConstraint to recognise amdgpu specific register names. https://reviews.llvm.org/D44533 Files: lib/Basi