[PATCH] D44508: Remove unnecessary include from Driver.cpp

2018-03-16 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi updated this revision to Diff 138671. yamaguchi added a comment. @marsupial Thanks for the commment, found a bug in my script and fixed. Now this patch removes only includes which are not used in each TU. Repository: rL LLVM https://reviews.llvm.org/D44508 Files: clang/lib/Drive

[PATCH] D44508: Remove unnecessary include from Driver.cpp

2018-03-15 Thread Frederich Munch via Phabricator via cfe-commits
marsupial added a comment. Shouldn't the Translation Unit be responsible for knowing what it needs rather than hoping it's already been used somewhere up the chain. Perhaps std::unique_ptr and std::make_pair are too low level and one can assume, but https://reviews.llvm.org/D44509 seems like a p

[PATCH] D44508: Remove unnecessary include from Driver.cpp

2018-03-15 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi created this revision. yamaguchi added a reviewer: dlj. Herald added a subscriber: llvm-commits. Clang compiles and test passes without these includes. Repository: rL LLVM https://reviews.llvm.org/D44508 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp