abeserminji updated this revision to Diff 139102.
abeserminji added a comment.
Herald added a subscriber: llvm-commits.
Resolved a comment.
Repository:
rL LLVM
https://reviews.llvm.org/D44381
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/mips-as.c
test/Driver/mips-features.c
sdardis added a comment.
This patch looks mostly ok, but I think there are some small issues with it.
Can you separate the new warnings/error relating to -fno-pic / -mabicalls into
another patch from the change which alters the behaviour of __PIC__ / __pic__ ?
The title of the patch is misleadi
abeserminji created this revision.
abeserminji added reviewers: sdardis, petarj.
Herald added a subscriber: arichardson.
This patch makes Clang behave more like gcc.
- On N64 ABI, -mno-abicalls is needed to disable PIC. Warning is reported when
only -fno-pic/-fno-PIC is used.
- An error is repor
