[PATCH] D44347: [analyzer] symbol_iterator must iterate through the symbolic base.

2018-03-22 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC328247: [analyzer] Make symbol_iterator iterate over SVal's symbolic base. (authored by dergachev, committed by ). Reposi

[PATCH] D44347: [analyzer] symbol_iterator must iterate through the symbolic base.

2018-03-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. > Because string length is for now only composed of `CStringChecker`-tagged > metadata symbols and constants... Even if this was not the case, it is stil certain that string length is a `NonLoc`. And as such it is either a plain `nonloc::SymbolVal` that is unaffected or a

[PATCH] D44347: [analyzer] symbol_iterator must iterate through the symbolic base.

2018-03-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 137892. NoQ added a comment. Slightly simplify one of the tests. https://reviews.llvm.org/D44347 Files: include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h test/Analysis/symbol-reaper.c Index: test/Analysis/symbol-reaper.c

[PATCH] D44347: [analyzer] symbol_iterator must iterate through the symbolic base.

2018-03-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Leak false-negatives that result from bugs in `Environment::removeDeadBindings()` and `RegionStoreManager::removeDeadBindings()` are also only appearing due to the overall zombie symbol problem we have (https://reviews.llvm.org/D18860). The bugs are in the code that popula

[PATCH] D44347: [analyzer] symbol_iterator must iterate through the symbolic base.

2018-03-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs, baloghadamsoftware. I've been investigating a false positive that had a pointer-type symbol with a non-zero range which had its range forgott