[PATCH] D44327: ObjCARC: teach the cloner about funclets

2018-03-12 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r327336. Addressed comments in SVN r327351, because I forgot to incorporate them in the first try. Repository: rL LLVM https://reviews.llvm.org/D44327 ___ cfe-commits mailing list cfe

[PATCH] D44327: ObjCARC: teach the cloner about funclets

2018-03-09 Thread David Majnemer via Phabricator via cfe-commits
majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Transforms/ObjCARC/ObjCARCOpts.cpp:692 + DenseMap &BlockColors) { + auto *CI = dyn_cast(&I); + assert(CI && "CloneCallInst must r

[PATCH] D44327: ObjCARC: teach the cloner about funclets

2018-03-09 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd updated this revision to Diff 137867. compnerd added a comment. Use the BB colorizer to detect the token. Fortunately, there is no BB removal/splitting happening here, so there is no state to maintain. Repository: rL LLVM https://reviews.llvm.org/D44327 Files: lib/Transforms/Obj

[PATCH] D44327: ObjCARC: teach the cloner about funclets

2018-03-09 Thread David Majnemer via Phabricator via cfe-commits
majnemer added inline comments. Comment at: lib/Transforms/ObjCARC/ObjCARCOpts.cpp:701 + + if (auto *CleanupPad = dyn_cast(BB.getFirstNonPHI())) +OpBundles.emplace_back("funclet", CleanupPad); What if the cleanuppad was introduced in a block which branched t

[PATCH] D44327: ObjCARC: teach the cloner about funclets

2018-03-09 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd created this revision. compnerd added a reviewer: gottesmm. Herald added a subscriber: cfe-commits. compnerd added a reviewer: ahatanak. compnerd added subscribers: rnk, majnemer. In the case that the CallInst that is being moved has an associated operand bundle which is a funclet, the mo