[PATCH] D44300: [SemaOverload] Fixed crash on code completion

2018-03-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL327134: [SemaOverload] Fixed crash on code completion (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44300 Files: cfe/

[PATCH] D44300: [SemaOverload] Fixed crash on code completion

2018-03-09 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 137743. ilya-biryukov added a comment. - Added a comment Repository: rC Clang https://reviews.llvm.org/D44300 Files: lib/Sema/SemaOverload.cpp test/CodeCompletion/enable-if-attr-crash.cpp Index: test/CodeCompletion/enable-if-attr-crash.cpp ==

[PATCH] D44300: [SemaOverload] Fixed crash on code completion

2018-03-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaOverload.cpp:6251 + : P->getDefaultArg(); + if (!DefArg) +return false; comment this

[PATCH] D44300: [SemaOverload] Fixed crash on code completion

2018-03-09 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added reviewers: bkramer, sammccall, ioeric, hokein. The relevant failing assertion message is: ../tools/clang/lib/Sema/SemaInit.cpp:8411: PerformCopyInitialization(): Assertion `InitE && "No initialization expression?"' failed. See the added te