This revision was automatically updated to reflect the committed changes.
Closed by commit rL327127: [clangd] Don't index template specializations.
(authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44298?vs=137731
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: unittests/clangd/SymbolCollectorTests.cpp:200
+ UnorderedElementsAreArray(
+ {QName("Foo"), QName("f1"), QName("f2"), QName("KInt"),
QName("Tm
sammccall updated this revision to Diff 137731.
sammccall added a comment.
verify that we don't emit extra symbols in other template-related cases
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44298
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/SymbolCollectorTe
sammccall updated this revision to Diff 137729.
sammccall added a comment.
merge matchers
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44298
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/SymbolCollectorTests.cpp
Index: unittests/clangd/SymbolCollectorTests.cp
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
These have different USRs than the underlying entity, but are not typically
interesting in their own right and can be numerous (e.g. generated traits).
