[PATCH] D44294: [clangd] Fix diagnostic errors in the test code, NFC.

2018-03-12 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327293: [clangd] Fix diagnostic errors in the test code, NFC. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D44294?vs=137712&id=138039#toc Repository: rCTE

[PATCH] D44294: [clangd] Fix diagnostic errors in the test code, NFC.

2018-03-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added inline comments. This revision is now accepted and ready to land. Comment at: unittests/clangd/XRefsTests.cpp:587 - const char *HeaderContents = R"cpp([[]]int a;)cpp"; + const char *HeaderContents = R"cpp([[]]#ifndef T

[PATCH] D44294: [clangd] Fix diagnostic errors in the test code, NFC.

2018-03-09 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 137712. hokein marked an inline comment as done. hokein added a comment. Use #program once Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44294 Files: unittests/clangd/XRefsTests.cpp Index: unittests/clangd/XRefsTests.cpp ===

[PATCH] D44294: [clangd] Fix diagnostic errors in the test code, NFC.

2018-03-09 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: unittests/clangd/XRefsTests.cpp:587 - const char *HeaderContents = R"cpp([[]]int a;)cpp"; + const char *HeaderContents = R"cpp([[]]#ifndef TEST_H_ + #define TEST_H_ ilya-biryukov wr

[PATCH] D44294: [clangd] Fix diagnostic errors in the test code, NFC.

2018-03-09 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: unittests/clangd/XRefsTests.cpp:587 - const char *HeaderContents = R"cpp([[]]int a;)cpp"; + const char *HeaderContents = R"cpp([[]]#ifndef TEST_H_ + #define TEST_H_ I would g

[PATCH] D44294: [clangd] Fix diagnostic errors in the test code, NFC.

2018-03-09 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: ioeric, jkorous-apple, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44294 Files: unittests/clangd/XRefsTests.cpp Index: unittests/clangd/XRefsTests.cpp ==