espindola closed this revision.
espindola added a comment.
r327543
https://reviews.llvm.org/D44233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2618-2620
+const CXXRecordDecl *RD = nullptr;
+if (const auto *RecordTy = dyn_cast(Ty))
+ RD = cast(RecordTy->getDecl());
espindola added a comment.
ping
https://reviews.llvm.org/D44233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
espindola created this revision.
espindola added a reviewer: rnk.
In this particular case it would be possible to just add an else with
CGM.setDSOLocal(GV), but it seems better to have as many callers as possible
just call setGVProperties so that we can centralize the logic there.
This patch t
