[PATCH] D44231: Check for sizeof that call functions

2018-03-07 Thread Paul Fultz II via Phabricator via cfe-commits
pfultz2 updated this revision to Diff 137499. https://reviews.llvm.org/D44231 Files: clang-tidy/misc/SizeofExpressionCheck.cpp clang-tidy/misc/SizeofExpressionCheck.h test/clang-tidy/misc-sizeof-expression.cpp Index: test/clang-tidy/misc-sizeof-expression.cpp ==

[PATCH] D44231: Check for sizeof that call functions

2018-03-07 Thread Paul Fultz II via Phabricator via cfe-commits
pfultz2 updated this revision to Diff 137497. https://reviews.llvm.org/D44231 Files: clang-tidy/misc/SizeofExpressionCheck.cpp clang-tidy/misc/SizeofExpressionCheck.h test/clang-tidy/misc-sizeof-expression.cpp Index: test/clang-tidy/misc-sizeof-expression.cpp ==

[PATCH] D44231: Check for sizeof that call functions

2018-03-07 Thread Paul Fultz II via Phabricator via cfe-commits
pfultz2 updated this revision to Diff 137496. https://reviews.llvm.org/D44231 Files: clangd/CodeComplete.cpp test/clangd/protocol.test unittests/clangd/CodeCompleteTests.cpp Index: unittests/clangd/CodeCompleteTests.cpp === -

[PATCH] D44231: Check for sizeof that call functions

2018-03-07 Thread Paul Fultz II via Phabricator via cfe-commits
pfultz2 created this revision. pfultz2 added reviewers: clang-tools-extra, hokein, alexfh, aaron.ballman, ilya-biryukov. Herald added a subscriber: jkorous-apple. A common mistake that I have found in our codebase is calling a function to get an integer or enum that represents the type such as: