[PATCH] D44229: Don't use -pie in relocatable link.

This revision was automatically updated to reflect the committed changes. Closed by commit rC327165: Don't use -pie in relocatable link. (authored by eugenis, committed by ). Changed prior to commit: https://reviews.llvm.org/D44229?vs=137493&id=137809#toc Repository: rC Clang https://review

[PATCH] D44229: Don't use -pie in relocatable link.

eugenis added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:311 + if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_static) || + Args.hasArg(options::OPT_r)) return false; mgrang wrote: > We also need to check for -Wl,

[PATCH] D44229: Don't use -pie in relocatable link.

mgrang added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:311 + if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_static) || + Args.hasArg(options::OPT_r)) return false; We also need to check for -Wl,-r and -Xlinker -

[PATCH] D44229: Don't use -pie in relocatable link.

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks for fixing this quickly. :) https://reviews.llvm.org/D44229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D44229: Don't use -pie in relocatable link.

eugenis created this revision. eugenis added a reviewer: srhines. Android, in particular, got PIE enabled by default in r316606. It resulted in relocatable links passing both -r and -pie to the linker, which is not allowed. https://reviews.llvm.org/D44229 Files: clang/lib/Driver/ToolChains/Gn