This revision was automatically updated to reflect the committed changes.
Closed by commit rL327009: [clangd:vscode] Resolve symlinks for file paths from
clangd. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44158
F
ioeric added inline comments.
Comment at: clangd/clients/clangd-vscode/src/extension.ts:3
import * as vscodelc from 'vscode-languageclient';
+import { realpathSync } from 'fs';
sammccall wrote:
> nit: the braces don't do anything here, right?
I'm not sure... t
ioeric updated this revision to Diff 137564.
ioeric marked an inline comment as done.
ioeric added a comment.
- add context about the workaround.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44158
Files:
clangd/clients/clangd-vscode/src/extension.ts
Index: clangd/clients/
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LG. Can you expand the comment and fix the formatting changes?
Comment at: clangd/clients/clangd-vscode/src/extension.ts:3
import * as vscodelc from 'vscode-languagecl
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
For features like go-to-definition, clangd can point clients to symlink paths
(e.g. in bazel execroot) which might not be desired if the symlink points to
