[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-07-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. In https://reviews.llvm.org/D44143#1152550, @boga95 wrote: > How can I commit it? You need to have obtained commit access first. I went ahead and committed on your behalf in r336301. Thank you for the patch!

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-07-04 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. How can I commit it? Comment at: docs/clang-tidy/checks/cert-msc51-cpp.rst:7 +This check flags all pseudo-random number engines, engine adaptor +instantiations and `srand()` when initialized or seeded with default argument, +constant expression or any us

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-07-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. This still LGTM; do you need someone to commit on your behalf? https://reviews.llvm.org/D44143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-07-01 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 153655. https://reviews.llvm.org/D44143 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp clang-tidy/cert/ProperlySeededRandomGeneratorCheck.h docs/ReleaseNotes.rst docs/

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-06-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small documentation nit. Comment at: docs/clang-tidy/checks/cert-msc51-cpp.rst:39 + + A comma-separated list of the type names which are disallowe

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-06-27 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 153172. boga95 marked 3 inline comments as done. https://reviews.llvm.org/D44143 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp clang-tidy/cert/ProperlySeededRandomGenerat

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-06-27 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 153169. boga95 marked 3 inline comments as done. https://reviews.llvm.org/D44143 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp clang-tidy/cert/ProperlySeededRandomGenerat

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-06-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp:24 +: ClangTidyCheck(Name, Context), + RawDisallowedSeedTypes(Options.get("DisallowedSeedTypes", "")) { + StringRef(RawDisallowedSeedTypes).split(DisallowedSeedTypes,

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-06-25 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 152778. boga95 marked 3 inline comments as done. boga95 added a comment. Add std::srand check to C++ tests. Format patch. https://reviews.llvm.org/D44143 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/ProperlyS

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-06-25 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/cert/CERTTidyModule.cpp:44 "cert-dcl54-cpp"); -CheckFactories.registerCheck( -"cert-dcl58-cpp"); + CheckFactories.registerCheck("cert-dcl58-cpp"); CheckFactories.registerCheck( -

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-06-24 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked 12 inline comments as done. boga95 added a comment. I think I resolved all of the comments. Do I forget anything? Comment at: clang-tidy/cert/CERTTidyModule.cpp:44 "cert-dcl54-cpp"); -CheckFactories.registerCheck( -"cert-dcl58-cpp"); + Che

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-05-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. This is getting closer, but it seems there are still unresolved comments from reviewers. Are you planning to resolve those as well? https://reviews.llvm.org/D44143 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-04-27 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 updated this revision to Diff 144336. https://reviews.llvm.org/D44143 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp clang-tidy/cert/ProperlySeededRandomGeneratorCheck.h docs/ReleaseNotes.rst docs/

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-03-13 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:63 + + Detects inappropriate seeding of C++ random generators and C srand function. + Please replace srand with ``srand ()``. Comment at: docs/clang-tidy/checks/cert-msc5

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-03-12 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/cert/CERTTidyModule.cpp:40 // DCL -CheckFactories.registerCheck( -"cert-dcl21-cpp"); +CheckFactories.registerCheck("cert-dcl21-cpp"); CheckFactories.registerCheck("cert-dcl50-cpp");

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

2018-03-12 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a subscriber: szepet. boga95 marked 4 inline comments as done. boga95 added inline comments. Comment at: test/clang-tidy/cert-properly-seeded-random-generator.cpp:76 + // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: random number generator must be seeded with a random