This revision was automatically updated to reflect the committed changes.
Closed by commit rL327194: [CMake] Copy the generated __config header into
build directory (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4
phosek added inline comments.
Comment at: libcxx/include/CMakeLists.txt:19
+DEPENDS ${LIBCXX_BINARY_DIR}/__generated_config)
+ set(generated_config_deps generate_config_header)
+endif()
compnerd wrote:
> Where is `generated_config_deps` used?
Line 69
Repos
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: libcxx/include/CMakeLists.txt:19
+DEPENDS ${LIBCXX_BINARY_DIR}/__generated_config)
+ set(generated_config_deps generate_config_header)
+endif()
-
phosek added a comment.
Ping again?
Repository:
rCXX libc++
https://reviews.llvm.org/D43797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phosek added a comment.
Ping? Can we land this as a temporary solution until the config generator logic
is rewritten? This is currently breaking the libFuzzer build for us.
Repository:
rCXX libc++
https://reviews.llvm.org/D43797
___
cfe-commits
phosek created this revision.
phosek added reviewers: EricWF, mclow.lists, beanz.
Herald added subscribers: cfe-commits, christof, mgorny.
When the generated __config file is being used, it is currently only
copied during installation process. However, that means that the file
that gets copied int
