This revision was automatically updated to reflect the committed changes.
Closed by commit rL326222: add UUID to the acronyms list of objc property name
checks (authored by Wizard, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43775
Fil
benhamilton added a comment.
LGTM.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE326222: add UUID to the acronyms list of objc property
name checks (authored by Wizard, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43775?vs=136100&id=136102#toc
Repository:
Wizard updated this revision to Diff 136100.
Wizard added a comment.
resolve comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43775
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
Index: clang-tidy/objc/PropertyDeclarationCheck.cpp
benhamilton accepted this revision.
benhamilton added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:52
"GIF",
"GPS",
"HD",
Might as well also add GUID.
Repository:
rC
hokein added a comment.
The change seems good to me. I'd leave the approval to @benhamilton since he
has more context on objc.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43775
___
cfe-commits mailing list
cfe-commits@lists.llv
Wizard created this revision.
Herald added subscribers: cfe-commits, klimek.
Wizard added reviewers: benhamilton, hokein.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43775
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
Index: clang-tidy/objc/PropertyDeclarationCheck.c
