[PATCH] D43732: Resolve build bot problems in unittests/Format/FormatTest.cpp

2018-02-27 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope added a comment. In https://reviews.llvm.org/D43732#1020639, @benhamilton wrote: > Actually, looks like all the other tests explicitly want a non-empty > in-memory FS, so there's no good cleanup I can do. Well, it was only this new test case that failed, so I think other tests are fine

[PATCH] D43732: Resolve build bot problems in unittests/Format/FormatTest.cpp

2018-02-27 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton added a comment. Actually, looks like all the other tests explicitly want a non-empty in-memory FS, so there's no good cleanup I can do. Repository: rC Clang https://reviews.llvm.org/D43732 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D43732: Resolve build bot problems in unittests/Format/FormatTest.cpp

2018-02-27 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton added a comment. Thanks for fixing this. (Sorry for not getting to it, I was away traveling until today.) I'll add a tidy-up in https://reviews.llvm.org/D43598 to ensure all tests which call `getStyle()` pass in an in-memory filesystem. Repository: rC Clang https://reviews.llvm

[PATCH] D43732: Resolve build bot problems in unittests/Format/FormatTest.cpp

2018-02-26 Thread Bjorn Pettersson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326086: Resolve build bot problems in unittests/Format/FormatTest.cpp (authored by bjope, committed by ). Changed prior to commit: https://reviews.llvm.org/D43732?vs=135794&id=135891#toc Repository:

[PATCH] D43732: Resolve build bot problems in unittests/Format/FormatTest.cpp

2018-02-24 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope added a comment. This is an attempt to fix problems seen after https://reviews.llvm.org/D43590 Repository: rC Clang https://reviews.llvm.org/D43732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D43732: Resolve build bot problems in unittests/Format/FormatTest.cpp

2018-02-24 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope created this revision. Herald added a subscriber: klimek. Make the new GetStyleWithEmptyFileName test case independent of the file system used when running the test. Since the test is supposed to use the fallback "Google" style we now use a InMemoryFileSystem to make sure that we do not acci