juliehockett closed this revision.
juliehockett added a comment.
Closed in r334103 .
https://reviews.llvm.org/D43667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett added inline comments.
Comment at: clang-doc/YAMLGenerator.cpp:265
+// and thus register the generator.
+volatile int YAMLGeneratorAnchorSource = 0;
+
ioeric wrote:
> nit: add `static`?
`static` declares it as file-local, and so the `extern` referenc
juliehockett updated this revision to Diff 149997.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D43667
Files:
clang-doc/CMakeLists.txt
clang-doc/Generators.cpp
clang-doc/Generators.h
clang-doc/Representation.h
cl
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang-doc/Generators.h:25
+//
+// Derived classes must implement the generate*ForInfo methods, which should
+// emit documentation for the specified info in
juliehockett updated this revision to Diff 149856.
juliehockett marked 4 inline comments as done.
juliehockett added a comment.
Addressing comments
https://reviews.llvm.org/D43667
Files:
clang-doc/CMakeLists.txt
clang-doc/Generators.cpp
clang-doc/Generators.h
clang-doc/Representation.h
ioeric added inline comments.
Comment at: clang-doc/Generators.h:25
+//
+// Derived classes must implement the generate*ForInfo methods, which should
+// emit documentation for the specified info in the relevant format. This is
nit: This seems a bit redundant as
juliehockett updated this revision to Diff 149373.
https://reviews.llvm.org/D43667
Files:
clang-doc/CMakeLists.txt
clang-doc/Generators.cpp
clang-doc/Generators.h
clang-doc/Representation.h
clang-doc/YAMLGenerator.cpp
clang-doc/tool/ClangDocMain.cpp
test/clang-doc/yaml-comments.cpp
juliehockett added inline comments.
Comment at: clang-doc/generators/Generators.h:49
+
+class GeneratorFactory {
+public:
ioeric wrote:
> ioeric wrote:
> > Please add documentation and explain why this is needed.
> If you plan to plugin in more generators (e.g.
juliehockett updated this revision to Diff 147606.
juliehockett marked 11 inline comments as done.
juliehockett edited the summary of this revision.
juliehockett added a comment.
Updating for better integration with MR framework, the generator now takes in
an info and an output stream and emits t
ioeric added inline comments.
Comment at: clang-doc/Representation.h:238
+ // Non-const accessors for YAML output.
+ std::vector &getNamespaceInfos() { return NamespaceInfos; }
There are two alternatives to avoid this:
1) Pull the info storage into a separate
Athosvk added a comment.
In https://reviews.llvm.org/D43667#1063049, @juliehockett wrote:
> In https://reviews.llvm.org/D43667#1062746, @Athosvk wrote:
>
> > I'm a bit late on this, but I'd say that YAML is usually not a 'final'
> > format. What would be the use-cases for this? And if is meant a
juliehockett added a comment.
In https://reviews.llvm.org/D43667#1062746, @Athosvk wrote:
> I'm a bit late on this, but I'd say that YAML is usually not a 'final'
> format. What would be the use-cases for this? And if is meant as an
> alternative intermediate format, why not instead of having o
Athosvk added a comment.
I'm a bit late on this, but I'd say that YAML is usually not a 'final' format.
What would be the use-cases for this? And if is meant as an alternative
intermediate format, why not instead of having one big file, have one file per
input file? Just wondering what the part
Athosvk added a comment.
I'm a bit late on this, but I'd say that YAML is usually not a 'final' format.
What would be the use-cases for this? And if is meant as an alternative
intermediate format, why not instead of having one big file, have one file per
input file? Just wondering what the part
juliehockett updated this revision to Diff 140021.
juliehockett added a comment.
Updating to for adjustments to the internal representation & cleaning up
duplication.
https://reviews.llvm.org/D43667
Files:
clang-doc/CMakeLists.txt
clang-doc/Representation.h
clang-doc/generators/CMakeList
juliehockett updated this revision to Diff 137272.
juliehockett marked 6 inline comments as done.
juliehockett added a comment.
Updating based on parent changes
https://reviews.llvm.org/D43667
Files:
clang-doc/CMakeLists.txt
clang-doc/Representation.h
clang-doc/generators/CMakeLists.txt
Eugene.Zelenko added a comment.
I may be mistaken, but Clang source code didn't use llvm namespace by default.
Insetad you should include clang/Basic/LLVM.h and use llvm:: for rest of things.
Comment at: clang-doc/tool/ClangDocMain.cpp:42
namespace {
Ther
Eugene.Zelenko added a comment.
Please run Clang-format and Clang-tidy modernize over new code.
Comment at: clang-doc/generators/Generators.h:29
+ Generator(std::unique_ptr &IS, StringRef Root, StringRef Format)
+ : IS(IS), Root(Root), Format(Format){};
+ virtual ~Genera
juliehockett created this revision.
juliehockett added reviewers: klimek, jakehehrlich, sammccall, lebedev.ri.
juliehockett added a project: clang-tools-extra.
Herald added a subscriber: mgorny.
juliehockett added a dependency: D43341: [clang-doc] Implement reducer portion
of the frontend framewor
19 matches
Mail list logo
