[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

bsdjhb updated this revision to Diff 136098. bsdjhb added a comment. - Match names used in libcxx and add LINKER_FLAGS. Repository: rUNW libunwind https://reviews.llvm.org/D43585 Files: CMakeLists.txt test/lit.site.cfg.in Index: test/lit.site.cfg.in

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D43585#1017957, @bsdjhb wrote: > My only question is if this should be named LIBUNWIND_TEST_COMPILER_FLAGS to > match the name used in libc++? I would say yes f

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

bsdjhb updated this revision to Diff 135714. bsdjhb added a comment. - Use STRING instead of PATH. - Update for committed libcxx change. Repository: rUNW libunwind https://reviews.llvm.org/D43585 Files: CMakeLists.txt test/lit.site.cfg.in Index: test/lit.site.cfg.in ===

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

bsdjhb marked 2 inline comments as done. bsdjhb added a comment. My only question is if this should be named LIBUNWIND_TEST_COMPILER_FLAGS to match the name used in libc++? Repository: rUNW libunwind https://reviews.llvm.org/D43585 ___ cfe-commi

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

sdardis added a subscriber: arichardson. sdardis added a comment. This works as expected with your corresponding libcxx patch. However @arichardson 's https://reviews.llvm.org/D42139 does similar things for libcxx. We should wait for that to land, and ensure that this patch is rebased against t

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

bsdjhb added a comment. @sdardis requested this functionality in the review of https://reviews.llvm.org/D39074. Simon, can you confirm that this works for you in your testing? Repository: rUNW libunwind https://reviews.llvm.org/D43585 ___ cfe-

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

bsdjhb updated this revision to Diff 135285. bsdjhb added a comment. - Unexpand tabs. Repository: rUNW libunwind https://reviews.llvm.org/D43585 Files: CMakeLists.txt test/lit.site.cfg.in Index: test/lit.site.cfg.in === --

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

bsdjhb created this revision. bsdjhb added a reviewer: sdardis. Herald added subscribers: christof, mgorny. This is done via a new LIBUNWIND_TEST_CFLAGS variable. Repository: rUNW libunwind https://reviews.llvm.org/D43585 Files: CMakeLists.txt test/lit.site.cfg.in Index: test/lit.site.