[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

This revision was automatically updated to reflect the committed changes. Closed by commit rL325760: [libcxx] Do not include the C math.h header before __config (authored by miyuki, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43579

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

mclow.lists added inline comments. Comment at: include/math.h:1499 +// has previously been included. +#if defined(_LIBCPP_MSVCRT) && defined(_USE_MATH_DEFINES) +#include_next pcc wrote: > Nit: you don't actually need the ` && defined(_USE_MATH_DEFINES)` part. I

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

pcc added inline comments. Comment at: include/math.h:1499 +// has previously been included. +#if defined(_LIBCPP_MSVCRT) && defined(_USE_MATH_DEFINES) +#include_next Nit: you don't actually need the ` && defined(_USE_MATH_DEFINES)` part. https://reviews.llvm.

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This LGTM. https://reviews.llvm.org/D43579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

miyuki created this revision. miyuki added a reviewer: mclow.lists. Herald added a reviewer: EricWF. Certain C libraries require configuration macros defined in __config to provide the correct functionality for libc++. This patch ensures that the C header math.h is always included after the __conf