This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL325779: [clangd] Correct setting ignoreWarnings in
CodeCompletion. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL L
hokein updated this revision to Diff 135399.
hokein added a comment.
- add a comment
- find one more incorrect usage, and fix it.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43569
Files:
clangd/CodeComplete.cpp
clangd/Headers.cpp
Index: clangd/Headers.cpp
=
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clangd/CodeComplete.cpp:705
}
+ CI->getDiagnosticOpts().IgnoreWarnings = true;
auto Clang = prepareCompilerInstance(
ilya-biryukov wrote:
> Could we add a comment that this
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a minor nit.
Comment at: clangd/CodeComplete.cpp:705
}
+ CI->getDiagnosticOpts().IgnoreWarnings = true;
auto Clang = prepareCompilerInstance(
-
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: ioeric, jkorous-apple, klimek.
We should set the flag before creating ComplierInstance -- when
CopmilerInstance gets initialized, it also initializes the DiagnosticsEngine
using the DiagnosticOptions.
