This revision was automatically updated to reflect the committed changes.
Closed by commit rL326342: [CUDA] Include single GPU binary, NFCI. (authored by
Hahnfeld, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43461?vs=135649&id=1363
Hahnfeld updated this revision to Diff 135649.
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
Update comment.
https://reviews.llvm.org/D43461
Files:
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGCUDANV.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Frontend/Compil
Hahnfeld added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1044-1045
- Opts.CudaGpuBinaryFileNames =
- Args.getAllArgValues(OPT_fcuda_include_gpubinary);
+ Opts.CudaGpuBinaryFileName =
+ Args.getLastArgValue(OPT_fcuda_include_gpubinary);
-
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Frontend/CompilerInvocation.cpp:1044-1045
- Opts.CudaGpuBinaryFileNames =
- Args.getAllArgValues(OPT_fcuda_include_gpubinary);
+ Opts.CudaGpuBinaryFile
Hahnfeld added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1044-1045
- Opts.CudaGpuBinaryFileNames =
- Args.getAllArgValues(OPT_fcuda_include_gpubinary);
+ Opts.CudaGpuBinaryFileName =
+ Args.getLastArgValue(OPT_fcuda_include_gpubinary);
-
tra added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4659
if (IsCuda) {
-// Host-side cuda compilation receives device-side outputs as Inputs[1...].
-// Include them with -fcuda-include-gpubinary.
+// Host-side cuda compilation receives device-sid
Hahnfeld created this revision.
Hahnfeld added reviewers: jlebar, tra.
Herald added a subscriber: cfe-commits.
Binaries for multiple architectures are combined by fatbinary,
so the current code was effectively not needed.
Repository:
rC Clang
https://reviews.llvm.org/D43461
Files:
include/
