This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341955: Reland "Implement a (simple) Markdown
generator" (authored by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43424?vs=161123&id=164903#toc
Repository:
rL L
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341955: Reland "Implement a (simple) Markdown
generator" (authored by juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43424?vs=1
juliehockett reopened this revision.
juliehockett added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: kadircet.
Reopening because it was reverted and I haven't had time to look into it yet
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43
This revision was automatically updated to reflect the committed changes.
juliehockett marked an inline comment as done.
Closed by commit rCTE339948: Implement a (simple) Markdown generator (authored
by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43424?vs=15
leonardchan accepted this revision.
leonardchan added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clang-doc/MDGenerator.cpp:79
+
+void writeHeader(const Twine &Text, int Num, raw_ostream &OS) {
+ OS << std::string(Num, '#') + "
juliehockett updated this revision to Diff 159091.
juliehockett marked an inline comment as done.
juliehockett added a comment.
Herald added a subscriber: arphaman.
Updating based on recent landed patches & updated tests
https://reviews.llvm.org/D43424
Files:
clang-tools-extra/clang-doc/CMake
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/clang-doc/MDGenerator.cpp:33
+ case AccessSpecifier::AS_none:
+return "";
+ }
return {};
https://reviews.llvm.org/D43424
___
cfe-commits mai
juliehockett updated this revision to Diff 152135.
juliehockett added a comment.
Updating to reflect changes to the framework (and make it work).
https://reviews.llvm.org/D43424
Files:
clang-tools-extra/clang-doc/CMakeLists.txt
clang-tools-extra/clang-doc/Generators.cpp
clang-tools-extra/
rja added inline comments.
Comment at: clang-doc/generators/MDGenerator.cpp:57
+ sys::path::native(NamespacesPath, Path);
+ // for (const auto &Namespace : I->Namespace)
+ // sys::path::append(Path, IS->find(Namespace)->Name);
remove commented code?
Reposi
ioeric added inline comments.
Comment at: clang-doc/generators/Generators.h:44
+class MDGenerator : public Generator {
+public:
Could you add high-level comment on what this does? This seems to build up some
directory structure and write different infos into d
Eugene.Zelenko added a comment.
Please run Clang-format and Clang-tidy modernize.
Comment at: clang-doc/generators/Generators.h:46
+public:
+ MDGenerator(std::unique_ptr &IS, StringRef Root, StringRef Format)
: Generator(IS, Root, Format) {};
+ virtual ~MDGenerator() {};
---
juliehockett updated this revision to Diff 135583.
juliehockett added a comment.
Updating based on parent revision changes -- still rough, will continue to
improve.
https://reviews.llvm.org/D43424
Files:
clang-doc/generators/CMakeLists.txt
clang-doc/generators/Generators.h
clang-doc/gene
lebedev.ri added a comment.
It will be good to have the tests for generators.
Comment at: clang-doc/generators/Generators.h:28
+public:
+ Generator(std::unique_ptr &IS, StringRef Root, StringRef Format) :
IS(IS), Root(Root), Format(Format) {};
+ virtual ~Generator() {};
juliehockett created this revision.
juliehockett added reviewers: klimek, jakehehrlich, sammccall.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: mgrang, mgorny.
juliehockett added a dependency: D43341: [clang-doc] Implement reducer portion
of the frontend framework.
I
14 matches
Mail list logo
