[PATCH] D43340: Clean up AMDGCN tests

2018-02-15 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC325279: Clean up AMDGCN tests (authored by yaxunl, committed by ). Changed prior to commit: https://reviews.llvm.org/D43340?vs=134445&id=134465#toc Repository: rC Clang https://reviews.llvm.org/D433

[PATCH] D43340: Clean up AMDGCN tests

2018-02-15 Thread Brian Sumner via Phabricator via cfe-commits
b-sumner accepted this revision. b-sumner added a comment. Looks good to me. https://reviews.llvm.org/D43340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43340: Clean up AMDGCN tests

2018-02-15 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D43340#1008980, @t-tye wrote: > LGTM Plus I think there was a test with giz in its name. Should that be > renamed? That's test/CodeGenOpenCL/amdgpu-env-amdgiz.cl. I already renamed it in my last commit. https://reviews.llvm.org/D43340 _

[PATCH] D43340: Clean up AMDGCN tests

2018-02-15 Thread Tony Tye via Phabricator via cfe-commits
t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM Plus I think there was a test with giz in its name. Should that be renamed? https://reviews.llvm.org/D43340 ___ cfe-commits mailing list cfe-c

[PATCH] D43340: Clean up AMDGCN tests

2018-02-15 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: t-tye, b-sumner. Remove amdgiz and use AMDGCN as check prefix. https://reviews.llvm.org/D43340 Files: test/CodeGen/address-space.c test/CodeGenCXX/cxx0x-initializer-stdinitializerlist.cpp test/CodeGenCXX/vla.cpp test/CodeGenOpenCL/ad