[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rC325238: Add Xray instrumentation compile-time/link-time support to FreeBSD (authored by kamil, committed by ). Repository: rC Clang https://reviews.llvm.org/D43279 Files: lib/Driver/ToolChains/FreeB

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

krytarowski added a comment. It looks good to me, I can land this for you. https://reviews.llvm.org/D43279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen updated this revision to Diff 134244. devnexen added a comment. Changing to pthread flag. https://reviews.llvm.org/D43279 Files: lib/Driver/ToolChains/FreeBSD.cpp Index: lib/Driver/ToolChains/FreeBSD.cpp === --- lib/Dr

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

krytarowski added inline comments. Comment at: FreeBSD.cpp:139 + CmdArgs.push_back("--no-as-needed"); + CmdArgs.push_back("-lpthread"); + CmdArgs.push_back("-lrt"); devnexen wrote: > krytarowski wrote: > > `-pthread`? > Did not seem needed maybe it s different

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen added inline comments. Comment at: FreeBSD.cpp:139 + CmdArgs.push_back("--no-as-needed"); + CmdArgs.push_back("-lpthread"); + CmdArgs.push_back("-lrt"); krytarowski wrote: > `-pthread`? Did not seem needed maybe it s different for NetBSD ? Repositor

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

krytarowski added inline comments. Comment at: FreeBSD.cpp:139 + CmdArgs.push_back("--no-as-needed"); + CmdArgs.push_back("-lpthread"); + CmdArgs.push_back("-lrt"); `-pthread`? Repository: rC Clang https://reviews.llvm.org/D43279 __

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D43279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen added a comment. Counterpart of the compiler-rt work here https://reviews.llvm.org/D43278 Repository: rC Clang https://reviews.llvm.org/D43279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen created this revision. devnexen added reviewers: vitalybuka, krytarowski. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, dberris, emaste. Similarly to the GNU driver version, adding proper compile and linker flags. Repository: rC Clang