mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM - thanks!
https://reviews.llvm.org/D43273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
STL_MSFT updated this revision to Diff 135352.
STL_MSFT added a comment.
Update based on code review feedback.
https://reviews.llvm.org/D43273
Files:
test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp
test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan_init_op.pass
mclow.lists added inline comments.
Comment at:
test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp:80
{
std::vector v(10);
std::iota(v.begin(), v.end(), 1);
What if we just made the containers `vector` ? (and `triangle`)
https:
STL_MSFT added a comment.
Would pragmas guarded by `_MSC_VER` be acceptable for the truncation warnings?
https://reviews.llvm.org/D43273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
mclow.lists added a comment.
The `` bit is fine.
The `veryLarge` is "ok".
The rest of them are just bogus.
https://reviews.llvm.org/D43273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
[libcxx] [test] Fix MSVC warnings and errors.
test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp
test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan_init_op.pass.cpp
test/std/numerics/numeric.
