This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG527a7fdfbd74: [libc++] Replace several uses of 0 by nullptr
(authored by brucem, committed by ldionne).
Repository:
rG
curdeius accepted this revision.
curdeius added a comment.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D43159/new/
https://reviews.llvm.org/D43159
___
cfe-commits mailing list
cfe-commits@lists.ll
ldionne updated this revision to Diff 307888.
ldionne marked 3 inline comments as done.
ldionne added a comment.
Apply review comments. Thanks for the catches!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D43159/new/
https://reviews.llvm.org/D43159
curdeius added inline comments.
Comment at: libcxx/include/functional:1759
typedef __base<_Rp(_ArgTypes...)> __func;
__func* __f_;
All uses of `__f_` should also use `nullptr`. If my search counted correctly,
there are 15 of them in `__value_func`.
curdeius added inline comments.
Comment at: libcxx/include/memory:4371
bool expired() const _NOEXCEPT
-{return __cntrl_ == 0 || __cntrl_->use_count() == 0;}
+{return __cntrl_ == nullptr || __cntrl_->use_count() == nullptr;}
shared_ptr<_Tp> lock() const _
ldionne accepted this revision.
ldionne added a comment.
I'll ship this if CI passes, since I addressed all comments we had originally.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D43159/new/
https://reviews.llvm.org/D43159
__
ldionne updated this revision to Diff 307402.
ldionne added a comment.
Herald added a project: libc++abi.
Herald added a reviewer: libc++abi.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D43159/new/
https://reviews.llvm.org
