This revision was automatically updated to reflect the committed changes.
Closed by commit rL324732: [clangd] Fix crash when CompilerInvocation
can't be created. (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43122
ilya-biryukov updated this revision to Diff 133593.
ilya-biryukov marked 4 inline comments as done.
ilya-biryukov added a comment.
- Removed assert that is now redundant
- Moved EXPECT_ERROR to Matchers.h
- Added more context into EXPECT_ERROR's error message
Repository:
rCTE Clang Tools Extra
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
just nits
Comment at: clangd/ClangdUnit.cpp:417
}
assert(CI && "Couldn't create CompilerInvocation");
remove?
Comment at: un
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric, sammccall.
Herald added subscribers: jkorous-apple, klimek.
This can happen if the CompileCommand provided by compilation database
is malformed.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D431
