[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

2018-02-12 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC324913: [Sema] Don't mark plain MS enums as fixed (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D43110?vs=133670&id=133887#toc Repository: rC Clang https://revi

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

2018-02-12 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324913: [Sema] Don't mark plain MS enums as fixed (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43110?vs=133670&id=133886#

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

2018-02-12 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In https://reviews.llvm.org/D43110#1004107, @rsmith wrote: > Thanks! I'd noticed this weirdness but wasn't sure what we could do about it > without breaking MS compat. I like this approach a lot. Great, sorry for the delay. > If we want to change the C behavior too, I thi

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

2018-02-09 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. Thanks! I'd noticed this weirdness but wasn't sure what we could do about it without breaking MS compat. I like this approach a lot. If we want to change the C behavior too, I think that should be a separate change. How does MSVC behave in

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

2018-02-09 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In https://reviews.llvm.org/D43110#1003171, @thakis wrote: > Nice! > > Test? Yeah, I forgot to get that in. From the test you can see that we have weirdly different behavior in C and C++ mode. Do people care? This is pre-existing behavior. My change makes the enum "unfixe

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

2018-02-09 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 133670. rnk added a comment. - Add test, update comments https://reviews.llvm.org/D43110 Files: clang/include/clang/AST/Decl.h clang/include/clang/Sema/Sema.h clang/lib/AST/Type.cpp clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaTemplateInstantiateDec

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

2018-02-09 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Nice! Test? https://reviews.llvm.org/D43110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

2018-02-08 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. We've seen lots of spurious warnings from this. Thanks for the fix! https://reviews.llvm.org/D43110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

2018-02-08 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D43110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

2018-02-08 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added a reviewer: rsmith. This fixes a flaw in our AST: PR27098 MSVC always gives plain enums the underlying type 'int'. Clang does this as well, but we claim the enum is "fixed", as if the user actually wrote ': int'. It means we end up emitting spurious -Wsign-com