mgrang added a comment.
After addressing comments, I have now committed this patch. Thanks for all the
reviews!
Repository:
rC Clang
https://reviews.llvm.org/D43105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326045: [RISCV] Enable __int128_t and __uint128_t through
clang flag (authored by mgrang, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4310
mgrang updated this revision to Diff 135553.
Repository:
rC Clang
https://reviews.llvm.org/D43105
Files:
include/clang/Basic/TargetInfo.h
include/clang/Basic/TargetOptions.h
include/clang/Driver/Options.td
lib/Basic/Targets/Mips.h
lib/Driver/ToolChains/Clang.cpp
lib/Frontend/Compil
asb added inline comments.
Comment at: test/CodeGen/riscv32-abi.c:2-3
// RUN: %clang_cc1 -triple riscv32 -emit-llvm %s -o - | FileCheck %s
+// RUN: %clang_cc1 -triple riscv32 -emit-llvm -fforce-enable-int128 %s -o - \
+// RUN: | FileCheck %s -check-prefix=CHECK-FORCEINT128
---
mgrang updated this revision to Diff 135540.
mgrang added a comment.
Thanks @asb. I have addressed your comments.
Repository:
rC Clang
https://reviews.llvm.org/D43105
Files:
include/clang/Basic/TargetInfo.h
include/clang/Basic/TargetOptions.h
include/clang/Driver/Options.td
lib/Basic
asb accepted this revision.
asb added a comment.
I've added two suggestions on further tweaking the tests which I think it would
be worth adopting. Looks good to me.
Comment at: test/CodeGen/riscv32-abi.c:424-430
+
+// RUN: %clang_cc1 -triple riscv32 -fforce-enable-int128 \
+/
mgrang added a comment.
Added tests for ABI lowering and preprocessor defines as per comments.
Repository:
rC Clang
https://reviews.llvm.org/D43105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
mgrang updated this revision to Diff 135493.
mgrang retitled this revision from "[RISCV] Enable __int128_t and uint128_t
through clang flag" to "[RISCV] Enable __int128_t and __uint128_t through clang
flag".
mgrang edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm