This revision was automatically updated to reflect the committed changes.
Closed by commit rL324674: Add X86 Support to ValidCPUList (enabling march
notes) (authored by erichkeane, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43041?
erichkeane updated this revision to Diff 133456.
erichkeane added a comment.
Cleaned up the test as suggested.
https://reviews.llvm.org/D43041
Files:
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
test/Misc/target-invalid-cpu-note.c
Index: test/Misc/target-invalid-cpu-note.c
Hahnfeld added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:1670-1672
+#define PROC_ALIAS(ENUM, ALIAS)
\
+ if (checkCPUKind(getCPUKind(ALIAS)))
\
+Values.emplace_back(ALIAS);
-
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D43041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Hahnfeld added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:1670-1672
+#define PROC_ALIAS(ENUM, ALIAS)
\
+ if (checkCPUKind(getCPUKind(ALIAS)))
\
+Values.emplace_back(ALIAS);
-
erichkeane updated this revision to Diff 133443.
erichkeane added a comment.
removed careless newline, also rebases off ARM patch.
https://reviews.llvm.org/D43041
Files:
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
test/Misc/target-invalid-cpu-note.c
Index: test/Misc/target-invalid
erichkeane created this revision.
erichkeane added reviewers: samparker, fhahn, rengolin, echristo, craig.topper.
A followup to: https://reviews.llvm.org/D42978
This patch adds X86 and X86_64 support for
enabling the march notes.
Repository:
rC Clang
https://reviews.llvm.org/D43041
Files:
