[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

2020-12-08 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ https://reviews.llvm.org/D43002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

2020-11-18 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ https://reviews.llvm.org/D43002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

2020-11-11 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea updated this revision to Diff 304364. aganea edited the summary of this revision. aganea edited reviewers, added: mstorsjo; removed: reames, espindola. aganea added a comment. Simplify. Added coverage when using `clang-cl` since this is a MSVC-specific feature. When `-fdebug-compilation-dir

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

2020-05-29 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea updated this revision to Diff 267111. aganea added a comment. Simplified. Now using `CodeGenOptions` to pass the object filename around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ https://reviews.llvm.org/D43002 Files: clang

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

2020-05-29 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. In D43002#2061162 , @echristo wrote: > First question: > > Since split dwarf has to do some similar things can we not use the same > support? This seems to be a lot of changes for this. > > Second question: > > and if we can't use

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

2020-05-28 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. First question: Since split dwarf has to do some similar things can we not use the same support? This seems to be a lot of changes for this. Second question: and if we can't use the same support can we make split dwarf use this? Having two separate methods for passin

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

2020-05-28 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea updated this revision to Diff 266989. aganea added a comment. Herald added subscribers: cfe-commits, steven_wu, aheejin, arichardson, sbc100, emaste. Herald added a reviewer: espindola. Herald added a project: clang. I'm taking over this patch, as discussed offline with Zachary. I've re-i