[PATCH] D42924: Don't pass ForDefinition_t in places it is redundant.

2018-02-07 Thread Rafael Avila de Espindola via Phabricator via cfe-commits
espindola closed this revision. espindola added a comment. r324499 https://reviews.llvm.org/D42924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42924: Don't pass ForDefinition_t in places it is redundant.

2018-02-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I'm guessing things were structured this way so that a function definition could have its visibility set before giving it a body, i.e. it would look like a declaration, but the visibility shou

[PATCH] D42924: Don't pass ForDefinition_t in places it is redundant.

2018-02-07 Thread Rafael Avila de Espindola via Phabricator via cfe-commits
espindola added a comment. Ping. https://reviews.llvm.org/D42924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42924: Don't pass ForDefinition_t in places it is redundant.

2018-02-05 Thread Rafael Avila de Espindola via Phabricator via cfe-commits
espindola created this revision. espindola added reviewers: sfertile, rnk. I found this while looking at the ppc failures caused by the dso_local change. The issue was that the patch would produce the wrong answer for available_externally. Having ForDefinition_t available in places where the co