This revision was automatically updated to reflect the committed changes.
Closed by commit rL329515: [libclang] Add clang_File_tryGetRealPathName
(authored by MaskRay, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42893?vs=141496&id=
MaskRay added a comment.
Done.
ninja -C ~/Dev/llvm/debug unittests/libclang/libclangTests
~/Dev/llvm/debug/tools/clang/unittests/libclang/libclangTests
Repository:
rC Clang
https://reviews.llvm.org/D42893
___
cfe-commits mailing list
cfe-com
MaskRay updated this revision to Diff 141496.
MaskRay added a comment.
Add unittests/libclang/LibclangTest.cpp test
Repository:
rC Clang
https://reviews.llvm.org/D42893
Files:
include/clang-c/Index.h
tools/libclang/CIndex.cpp
tools/libclang/libclang.exports
unittests/libclang/Libclan
MaskRay updated this revision to Diff 141492.
MaskRay added a comment.
Rebase
Repository:
rC Clang
https://reviews.llvm.org/D42893
Files:
include/clang-c/Index.h
tools/libclang/CIndex.cpp
tools/libclang/libclang.exports
Index: tools/libclang/libclang.exports
=
jbcoe added a comment.
Tests for libclang are in clang/unittests/libclang/LibclangTest.cpp
Given the surgical nature of this change I hope it will be quick to add a test.
Repository:
rC Clang
https://reviews.llvm.org/D42893
___
cfe-commits maili
jbcoe added a comment.
I’ll see if I can find a suitable location for a test.
Repository:
rC Clang
https://reviews.llvm.org/D42893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay added a comment.
There is no unittest but I have verified with a C++ language server on Arch
Linux. Without using this function, cquery/ccls will not be able to index
system header files because of excessive .. in the path returned by
clang_getFileName.
Repository:
rC Clang
https:/
MaskRay added a comment.
In https://reviews.llvm.org/D42893#1053754, @jbcoe wrote:
> Can you add some simple tests?
Where should I add tests? I cannot find tests for other clang_File_* functions.
Repository:
rC Clang
https://reviews.llvm.org/D42893
__
jbcoe requested changes to this revision.
jbcoe added a comment.
This revision now requires changes to proceed.
Can you add some simple tests?
Repository:
rC Clang
https://reviews.llvm.org/D42893
___
cfe-commits mailing list
cfe-commits@lists.llv
MaskRay added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D42893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D42893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay added a comment.
On Arch Linux,
`../lib64/gcc/x86_64-pc-linux-gnu/7.2.1/../../../../include/c++/7.2.1` (Name)
resolves to a path that requires leading path components (`/usr/include`), this
kind of resembles jailbreak.
Repository:
rC Clang
https://reviews.llvm.org/D42893
___
MaskRay updated this revision to Diff 132774.
MaskRay added a comment.
Increase CINDEX_VERSION_MINOR
Repository:
rC Clang
https://reviews.llvm.org/D42893
Files:
include/clang-c/Index.h
tools/libclang/CIndex.cpp
tools/libclang/libclang.exports
Index: tools/libclang/libclang.exports
==
MaskRay updated this revision to Diff 132775.
MaskRay added a comment.
description
Repository:
rC Clang
https://reviews.llvm.org/D42893
Files:
include/clang-c/Index.h
tools/libclang/CIndex.cpp
tools/libclang/libclang.exports
Index: tools/libclang/libclang.exports
MaskRay updated this revision to Diff 132773.
MaskRay added a comment.
description
Repository:
rC Clang
https://reviews.llvm.org/D42893
Files:
include/clang-c/Index.h
tools/libclang/CIndex.cpp
tools/libclang/libclang.exports
Index: tools/libclang/libclang.exports
MaskRay created this revision.
Herald added a subscriber: cfe-commits.
clang_getFileName() may return a path relative to WorkingDir.
On Arch Linux, during clang_indexTranslationUnit(), clang_getFileName() on
CXIdxIncludedIncludedFileInfo::file may return
"/../lib64/gcc/x86_64-pc-linux-gnu/7.3.0/..
16 matches
Mail list logo
