This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323992: [clangd] Log dropped diagnostics. (authored by
ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42803?vs=132430&id=132432#toc
Repository:
rCTE Clang Tools Extra
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323992: [clangd] Log dropped diagnostics. (authored by
ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42803
Files:
clang-tools-extr
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:182
+ SmallString<64> Message;
+ D.FormatDiagnostic(Message);
+
sammccall wrote:
> does Message include file:line? we probably want that in the log line.
No, it didn't include the line befor
ilya-biryukov updated this revision to Diff 132430.
ilya-biryukov added a comment.
- Show location of dropped diagnostic.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42803
Files:
clangd/ClangdUnit.cpp
Index: clangd/ClangdUnit.cpp
=
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/ClangdUnit.cpp:182
+ SmallString<64> Message;
+ D.FormatDiagnostic(Message);
+
does Message include file:line? we probably wan
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric, sammccall.
Herald added subscribers: jkorous-apple, klimek.
clangd drops diagnostics coming outside the main file, but it is still
useful to see that something went wrong in the logs.
Repository:
rCTE Clang Too
