[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

2018-12-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/IoFunctionsCheck.cpp:47-49 + "consider to cast the return value of %0 from type integer to type char, " + "possible loss of precision if an error has occurred or the end " + "of file has been rea

[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

2018-12-11 Thread Gábor Horváth via Phabricator via cfe-commits
hgabii marked 3 inline comments as done. hgabii added inline comments. Comment at: clang-tidy/bugprone/IoFunctionsCheck.cpp:32 +has(cxxMemberCallExpr( +on(hasType(namedDecl(hasAnyName("istream", +callee(cxxMethodDecl(has

[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

2018-12-11 Thread Gábor Horváth via Phabricator via cfe-commits
hgabii updated this revision to Diff 177713. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42682/new/ https://reviews.llvm.org/D42682 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/IoFun

[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

2018-12-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/IoFunctionsCheck.cpp:32 +has(cxxMemberCallExpr( +on(hasType(namedDecl(hasAnyName("istream", +callee(cxxMethodDecl(hasName("get")).bind("DeclOfGet")

[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

2018-12-04 Thread Gábor Horváth via Phabricator via cfe-commits
hgabii updated this revision to Diff 176736. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42682/new/ https://reviews.llvm.org/D42682 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/IoFun

[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

2018-12-04 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/bugprone-io-functions.rst:4 +bugprone-io-functions += + Please adjust length. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

2018-12-04 Thread Gábor Horváth via Phabricator via cfe-commits
hgabii marked an inline comment as done. hgabii added a comment. I moved to bugprone module and renamed to bugprone-io-functions. I added as a reference for cert-fio34-c. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42682/new/ https://reviews.llvm.

[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

2018-12-04 Thread Gábor Horváth via Phabricator via cfe-commits
hgabii updated this revision to Diff 176732. hgabii marked an inline comment as done. hgabii edited the summary of this revision. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42682/new/ https://reviews.llvm.org/D42682 Files: clang-tidy/bugprone/Bu

[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

2018-07-11 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. (removing from my dashboard) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42682 ___ cfe-commits mailing list cfe-com

[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

2018-07-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/BugproneTidyModule.cpp:84 +CheckFactories.registerCheck( +"bugprone-io-functions-misused"); CheckFactories.registerCheck( This name reads a bit awkwardly because usually "misuse