thakis closed this revision.
thakis added a comment.
r323426, thanks!
https://reviews.llvm.org/D42497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D42497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
thakis added inline comments.
Comment at: lib/Driver/ToolChains/Arch/X86.cpp:43
if (const Arg *A = Args.getLastArg(options::OPT__SLASH_arch)) {
+// Mapping built by looking at lib/Basic's X86TargetInfo::initFeatureMap().
hans wrote:
> I wonder if it woul
thakis updated this revision to Diff 131428.
thakis edited the summary of this revision.
https://reviews.llvm.org/D42497
Files:
lib/Driver/ToolChains/Arch/X86.cpp
test/Driver/cl-x86-flags.c
Index: test/Driver/cl-x86-flags.c
===
hans added a comment.
Thanks for looking into this!
Comment at: lib/Driver/ToolChains/Arch/X86.cpp:43
if (const Arg *A = Args.getLastArg(options::OPT__SLASH_arch)) {
+// Mapping built by looking at lib/Basic's X86TargetInfo::initFeatureMap().
I wonder
thakis created this revision.
thakis added a reviewer: rnk.
Herald added subscribers: fedor.sergeev, kristof.beyls, sdardis, emaste,
aemerson.
r213083 initially implemented /arch: support by mapping it to CPU features.
Then r241077 additionally mapped it to CPU, which made the feature flags
red
