This revision was automatically updated to reflect the committed changes.
Closed by commit rL323408: [clangd] Limit completion results. (authored by
hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42484
Files:
clang-tools-extra/
hokein updated this revision to Diff 131394.
hokein marked 4 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42484
Files:
clangd/CodeComplete.cpp
clangd/index/Merge.cpp
clangd/tool/ClangdMain.cpp
u
hokein added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:131
+ "0 means no limit."),
+llvm::cl::init(100), llvm::cl::Hidden);
+
sammccall wrote:
> I think we probably want to keep the default at 0 for now. I'm fine with 100
> pe
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thank you!
Comment at: clangd/tool/ClangdMain.cpp:128
+static llvm::cl::opt LimitCompletionResult(
+"limit-completion-results",
+llvm::cl::desc("Limit the numbe
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek.
- truncate symbols from static/dynamic index to the limited number
(which would save lots of cost in constructing the merged symbols).
- add an CLI option all
